Changeset 28

Timestamp:

05/29/06 16:21:20 (3 years ago)

Author:

mk

Message:

Add only non-empty files to Cheesecake index (closes ticket #6).

Files:

• branches/mk/cheesecake/cheesecake_index.py (modified) (1 diff)
• branches/mk/tests/_mockup_cheesecake.py (modified) (1 diff)
• branches/mk/tests/test_cheese_files.py (modified) (1 diff)

branches/mk/cheesecake/cheesecake_index.py

@@ -634 +634 @@
-
-                cheese_file = self.which_cheese_file(file)
-
+ and os.path.getsize(fullpath) != 0
-                    if cheese_file in self.critical_cheese_files:
-                        value = self.INDEX_FILE_CRITICAL

branches/mk/tests/_mockup_cheesecake.py

@@ -43 +43 @@
-        for f in files:
-            fd = file(os.path.join(self.temp_top_dir, f), "w")
+            fd.write('not_empty')
+            fd.close()
+
+    def create_empty_files(self, files):
+        for f in files:
+            fd = file(os.path.join(self.temp_top_dir, f), "w")
-            fd.close()
-

branches/mk/tests/test_cheese_files.py

@@ -52 +52 @@
-        assert critical_in_log('setup.py', loglines)
-        assert cheesefile_in_log('news', loglines)
+
+
+class TestEmptyCheeseFiles(MockupCheesecake):
+    def test_empty_filenames(self):
+        empty_filenames = self.prefix_with_package_name(['Readme',
+                                                         'INSTALL',
+                                                         'setup.py'])
+        self.create_empty_files(empty_filenames)
+        self.cheesecake.walk_pkg()
+
+        loglines = readlines_from_file(self._mock_logfile)
+
+        assert not critical_in_log('readme', loglines)
+        assert not cheesefile_in_log('install', loglines)
+        assert not critical_in_log('setup.py', loglines)