Changeset 173

Timestamp:

02/04/07 13:17:30 (2 years ago)

Author:

mk

Message:

Stop pylint when it exceeds 60 seconds of running time (closes ticket #48).

Files:

• trunk/cheesecake/cheesecake_index.py (modified) (4 diffs)
• trunk/cheesecake/util.py (modified) (2 diffs)
• trunk/tests/unit/test_index_class.py (modified) (2 diffs)

trunk/cheesecake/cheesecake_index.py

@@ -432 +432 @@
-        """Iterate over each subindex and yield their values.
-        """
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
-
-    def compute_with(self, cheesecake):
@@ -1049 +1054 @@
-    pylint_args = ' '.join(map(lambda x: '--disable-msg=%s' % x, disabled_messages))
-
+    max_execution_time = 60
+
-    def compute(self, files_list, package_dir):
-        # See if pylint script location is set via environment variable
@@ -1080 +1087 @@
-            self.cheesecake.log.debug("Running pylint on files: %s." % filenames)
-
-
+
+
+
-            if rc:
+                if output == 'Time exceeded':
+                    # Raise and exception what will cause PyLint to be removed from list of indices
+                    #   and thus won't affect the score.
+                    self.cheesecake.log.debug("pylint exceeded maximum execution time of %d seconds and was terminated." % \
+                                              self.max_execution_time)
+                    raise OSError
-                self.cheesecake.log.debug("encountered an error (%d):\n***\n%s\n***\n" % (rc, output))
-                error_count += 1
@@ -1735 +1750 @@
-        specific indexes.
-        """
-        # Recursively compute all indices.
-        max_cheesecake_index = self.index.max_value
-
-        # Pass Cheesecake instance to the main Index object.
-        cheesecake_index = self.index.compute_with(self)
+
+        # Get max value *after* computing indices, because computing
+        #   process can remove some indices from the list.
+        max_cheesecake_index = self.index.max_value
+
-        percentage = (cheesecake_index * 100) / max_cheesecake_index
-

trunk/cheesecake/util.py

@@ -4 +4 @@
-import os
-import shutil
+import signal
-import sys
-import tarfile
@@ -14 +15 @@
-PAD_VALUE = 4
-
-
+, max_timeout=None
-    """Run command and return its return code and its output.
-
-    >>> run_cmd('/bin/true')
-    (0, '')
+
+    >>> run_cmd('/bin/cat', max_timeout=0.2)
+    (1, 'Time exceeded')
-    """
-    arglist = cmd.split()
-    try:
-        p = Popen(arglist, stdout=PIPE, stderr=STDOUT, env=env)
-ProcessError
+Exception
-        return 1, e
+
+    # Wait only max_timeout seconds.
+    if max_timeout:
+        start = time.time()
+        while p.poll() is None:
+            time.sleep(0.1)
+            if time.time() - start > max_timeout:
+                os.kill(p.pid, signal.SIGINT)
+                p.wait()
+                return 1, "Time exceeded"
+
-    output = p.communicate()[0]
-    return p.returncode, output

trunk/tests/unit/test_index_class.py

@@ -3 +3 @@
-    >>> import _path_cheesecake
-    >>> from cheesecake.cheesecake_index import Index
+    >>> from _helper_cheesecake import Glutton
-
-*****
@@ -84 +85 @@
-    >>> new.requirements
-    ['one', 'two', 'three', 'four']
+
+*****
+
+Index which throws an Exception during computation will
+get removed from the list of subindices.
+    >>> class BadIndex(Index):
+    ...     max_value = 10
+    ...     def compute(self):
+    ...         raise Exception("No reason.")
+    >>> bad_index = BadIndex()
+    >>> index = Index(bad_index)
+    >>> bad_index in index.subindices
+    True
+    >>> index.compute_with(Glutton())
+    0
+    >>> bad_index in index.subindices
+    False
+    >>> index.max_value
+    0
-"""