Changeset 159

Timestamp:

12/22/06 22:42:05 (2 years ago)

Author:

grig

Message:

Added pep8.py from Johann Rocholl and corresponding IndexPEP8 as part of the code kwalitee index.

Corrected minor misspellings.

Files:

• trunk/cheesecake/cheesecake_index.py (modified) (8 diffs)
• trunk/cheesecake/pep8.py (added)
• trunk/tests/unit/test_index_class.py (modified) (1 diff)

trunk/cheesecake/cheesecake_index.py

@@ -33 +33 @@
-from util import time_function
-from codeparser import CodeParser
-
+
+
-
-__docformat__ = 'reStructuredText en'
@@ -90 +91 @@
-        * special: .py file for special purposes
-
-
+s
-           filesystem. If you have to, check if file exists by yourself.
-
@@ -507 +508 @@
-        """
-        if not isinstance(index, Index):
-ve
+s
-
-        self.subindices.append(index)
@@ -579 +580 @@
-        >>> opt_ext = WithOptionalExt('readme', ['html', 'txt'])
-
-ve
+s
-        >>> str(one_of) == str(opt_ext)
-        True
@@ -760 +761 @@
-    and how far from it actual package was.
-
-ve
+s
-    a given software package.
-    """
@@ -989 +990 @@
-
-class IndexUnitTested(Index):
-ve
+s
-    any of known test frameworks.
-    """
@@ -1002 +1003 @@
-
-        if unittests_count > 0:
-ve
+s
-            unit_tested = True
-
-        if get_files_of_type(files_list, 'test'):
-ve
+s
-            unit_tested = True
-
@@ -1119 +1120 @@
-        return not cheesecake.lite
-
+class IndexPEP8(Index):
+    """Compute PEP8 index for the modules in the package.
+    """
+    name = "pep8"
+    max_value = 0
+    error_score = -2
+    warning_score = -1
+
+
+    def compute(self, files_list, package_dir):
+        files_to_score = get_files_of_type(files_list, 'module')
+        if len(files_to_score) == 0:
+            self.value = 0
+            self.details = "no modules found"
+            return self.value
+
+        full_paths = [os.path.join(package_dir, file) for file in files_to_score]
+        arglist = ["-qq"] + full_paths
+        pep8.process_options(arglist)
+        for file in files_to_score:
+            fullpath = os.path.join(package_dir, file)
+            pep8.input_file(fullpath)
+        error_stats = pep8.get_error_statistics()
+        warning_stats = pep8.get_warning_statistics()
+        errors = len(error_stats)
+        warnings = len(warning_stats)
+        total_error_score = self.error_score * errors
+        total_warning_score = self.warning_score * warnings
+        score = total_error_score + total_warning_score
+
+        self.add_info("Errors:")
+        self.add_info("Count   Details")
+        for stat in error_stats:
+            self.add_info(stat)
+        self.add_info("pep8.py found %d error types; we're scoring %d per error type" % (errors, self.error_score))
+        self.add_info("Error score: %d" % total_error_score)
+        self.add_info("Warnings:")
+        self.add_info("Count   Details")
+        for stat in warning_stats:
+            self.add_info(stat)
+        self.add_info("pep8.py found %d warning types; we're scoring %d per warning type" % (warnings, self.warning_score))
+        self.add_info("Warning score: %d" % total_warning_score)
+        self.add_info("Total pep8 score: %d" % score)
+
+        self.value = score
+        self.details = "pep8.py check: %d error types, %d warning types" % (errors, warnings)
+        return self.value
+
-class IndexCodeKwalitee(Index):
-    name = "CODE KWALITEE"
-
-    subindices = [
-        IndexPyLint,
-        #IndexUnitTests,
-        IndexUnitTested,
+        IndexPyLint,
+        IndexPEP8,
-    ]
-

trunk/tests/unit/test_index_class.py

@@ -35 +35 @@
-    Traceback (most recent call last):
-      ...
-ve
+s
-
-Now remove subindex.