Changeset 109

Timestamp:

07/24/06 14:12:35 (2 years ago)

Author:

mk

Message:

Make pylint index work for long file lists.

Files:

• branches/mk/cheesecake/cheesecake_index.py (modified) (3 diffs)
• branches/mk/tests/unit/test_index_pylint.py (modified) (2 diffs)

branches/mk/cheesecake/cheesecake_index.py

@@ -307 +307 @@
-
-    return files, directories
+
+def length(L):
+    """Overall length of all strings in list.
+
+    >>> length(['a', 'bc', 'd', '', 'efg'])
+    7
+    """
+    return sum(map(lambda x: len(x), L))
+
+def generate_arguments(arguments, max_length):
+    """Pass list of strings in chunks of size not greater than max_length.
+
+    >>> for x in generate_arguments(['abc', 'def'], 4):
+    ...     print x
+    ['abc']
+    ['def']
+
+    >>> for x in generate_arguments(['a', 'bc', 'd', 'e', 'f'], 2):
+    ...     print x
+    ['a']
+    ['bc']
+    ['d', 'e']
+    ['f']
+
+    If a single argument is larger than max_length, ValueError is raised.
+        >>> L = []
+        >>> for x in generate_arguments(['abc', 'de', 'fghijk', 'l'], 4):
+        ...     L.append(x)
+        Traceback (most recent call last):
+          ...
+        ValueError: Argument 'fghijk' larger than 4.
+        >>> L
+        [['abc'], ['de']]
+    """
+    L = []
+    i = 0
+
+    # We have to look ahead, so C-style loop here.
+    while arguments:
+        if L == [] and len(arguments[i]) > max_length:
+            raise ValueError("Argument '%s' larger than %d." % (arguments[i], max_length))
+
+        L.append(arguments[i])
+
+        # End of arguments: yield then terminate.
+        if i == len(arguments) - 1:
+            yield L
+            break
+
+        # Adding next argument would exceed max_length, so yield now.
+        if length(L) + len(arguments[i+1]) > max_length:
+            yield L
+            L = []
+
+        i += 1
-
-################################################################################
@@ -957 +1012 @@
-
-    def compute(self, files_list, package_dir):
+        # Maximum length of arguments (not very precise).
+        max_arguments_length = 65536
+
-        # Exclude __init__.py files from score as they cause pylint
-        #     to fail with ImportError "Unable to find module for %s in %s".
@@ -973 +1031 @@
-        os.chdir(package_dir)
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-
-        # Switching back to the original cwd.
-        os.chdir(original_cwd)
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
-        self.value = int(ceil(pylint_score/10.0 * self.max_value))
-        self.details = "pylint score was %.2f out of 10" % pylint_score
-
-        return self.value

branches/mk/tests/unit/test_index_pylint.py

@@ +1 @@
+import os
+import shutil
+import tempfile
-
-import _path_cheesecake
-
+, create_empty_file
-from cheesecake.cheesecake_index import IndexPyLint
+from cheesecake import logger
-
-
@@ -19 +23 @@
-        print index.value
-        assert index.value == index.max_value
+
+    def test_long_file_list(self):
+        "Test if pylint index works for long files lists."
+        _package_dir = tempfile.mkdtemp()
+        _files_list = map(lambda x: 'long_module_with_a_number_%d.py' % x, xrange(4000))
+
+        for filename in _files_list:
+            create_empty_file(os.path.join(_package_dir, filename))
+
+        logger.setconsumer('console', logger.STDOUT)
+        console_log = logger.MultipleProducer('cheesecake console')
+
+        class CheesecakeMockup(object):
+            package_dir = _package_dir
+            files_list = _files_list
+            log = console_log
+
+        index = IndexPyLint()
+        cheesecake = CheesecakeMockup()
+
+        index.compute_with(cheesecake)
+        assert index.details != "encountered an error during pylint execution"
+
+        # Clean up.
+        shutil.rmtree(_package_dir)